[MINOR] fix: Fix LocalStorageManager divide by zero exception by leixm · Pull Request #900 · apache/uniffle · GitHub
Skip to content

[MINOR] fix: Fix LocalStorageManager divide by zero exception#900

Merged
roryqi merged 1 commit into
apache:masterfrom
leixm:divide_zero
May 23, 2023
Merged

[MINOR] fix: Fix LocalStorageManager divide by zero exception#900
roryqi merged 1 commit into
apache:masterfrom
leixm:divide_zero

Conversation

@leixm

@leixm leixm commented May 23, 2023

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Fix LocalStorageManager divide by zero exception when all local disks corrupted.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT.

@codecov-commenter

codecov-commenter commented May 23, 2023

Copy link
Copy Markdown

@leixm

leixm commented May 23, 2023

Copy link
Copy Markdown
Contributor Author

Flaky test.

@leixm

leixm commented May 23, 2023

Copy link
Copy Markdown
Contributor Author

cc @jerqi PTAL.

@leixm

leixm commented May 23, 2023

Copy link
Copy Markdown
Contributor Author

@roryqi roryqi changed the title Fix LocalStorageManager divide by zero exception [MINOR] fix: Fix LocalStorageManager divide by zero exception May 23, 2023

@roryqi roryqi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @leixm , merged to master & 0.7

@roryqi roryqi merged commit e6f8fcb into apache:master May 23, 2023
roryqi pushed a commit that referenced this pull request May 23, 2023
### What changes were proposed in this pull request?

Fix LocalStorageManager divide by zero exception when all local disks corrupted.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

UT.

Co-authored-by: leixianming <leixianming@didiglobal.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants