[BUG] Fix flaky test of AQESkewedJoinWithLocalOrderTest by zuston · Pull Request #350 · apache/uniffle · GitHub
Skip to content

[BUG] Fix flaky test of AQESkewedJoinWithLocalOrderTest#350

Merged
roryqi merged 1 commit into
apache:masterfrom
zuston:bug1
Nov 23, 2022
Merged

[BUG] Fix flaky test of AQESkewedJoinWithLocalOrderTest#350
roryqi merged 1 commit into
apache:masterfrom
zuston:bug1

Conversation

@zuston

@zuston zuston commented Nov 23, 2022

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Fix flaky test of AQESkewedJoinWithLocalOrderTest

  1. From the log of https://github.com/apache/incubator-uniffle/actions/runs/3524774587/jobs/5910627949, it looks the private @beforeAll identifier is invalid. So remove it

Why are the changes needed?

Fix flaky test

Does this PR introduce any user-facing change?

no

How was this patch tested?

UT

@codecov-commenter

codecov-commenter commented Nov 23, 2022

Copy link
Copy Markdown

@roryqi roryqi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston

@roryqi roryqi merged commit 3a8e29b into apache:master Nov 23, 2022
@roryqi

roryqi commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

@zuston

zuston commented Nov 23, 2022

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants