{{ message }}
[INFRA] Add k8s pipeline#340
Merged
Merged
Conversation
zuston
reviewed
Nov 18, 2022
Contributor
Author
There was a problem hiding this comment.
The operator is implemented by version 1.16 now. If necessary, we can upgrade it.
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
============================================
- Coverage 61.37% 58.17% -3.21%
Complexity 1529 1529
============================================
Files 186 192 +6
Lines 9445 10606 +1161
Branches 924 924
============================================
+ Hits 5797 6170 +373
- Misses 3340 4068 +728
- Partials 308 368 +60
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
Contributor
Author
kaijchen
reviewed
Nov 18, 2022
Member
There was a problem hiding this comment.
We can set if: ${{ matrix.profile == kubernetes}} here, although it is not required.
Contributor
Author
There was a problem hiding this comment.
Could you raise a good first issue about this optimization?
zuston
pushed a commit
that referenced
this pull request
Mar 5, 2026
…tting to avoid deadlock in decompression worker (#2737) ### What changes were proposed in this pull request? Release segmentPermits first to avoid deadlock ### Why are the changes needed? #2601 caused ShuffleReadClientImplTest to hang, see https://github.com/apache/uniffle/actions/runs/22700481546/job/65816264462?pr=2736 Threads dump: ``` "main" #1 prio=5 os_prio=31 tid=0x0000000152014000 nid=0x1a03 waiting on condition [0x000000016b5a9000] java.lang.Thread.State: WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x000000076c844f78> (a java.util.concurrent.CompletableFuture$Signaller) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) at java.util.concurrent.CompletableFuture$Signaller.block(CompletableFuture.java:1707) at java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3334) at java.util.concurrent.CompletableFuture.waitingGet(CompletableFuture.java:1742) at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908) at org.apache.uniffle.client.response.DecompressedShuffleBlock.getByteBuffer(DecompressedShuffleBlock.java:62) at org.apache.uniffle.client.response.DecompressedShuffleBlock.getUncompressLength(DecompressedShuffleBlock.java:53) at org.apache.uniffle.client.impl.DecompressionWorker.get(DecompressionWorker.java:165) at org.apache.uniffle.client.impl.ShuffleReadClientImpl.readShuffleBlockData(ShuffleReadClientImpl.java:329) at org.apache.uniffle.client.TestUtils.validateResult(TestUtils.java:55) at org.apache.uniffle.client.impl.ShuffleReadClientImplTest.readTest7(ShuffleReadClientImplTest.java:357) ``` ``` "decompressionWorker-0" #340 daemon prio=5 os_prio=31 tid=0x000000011b921000 nid=0x1481f waiting on condition [0x0000000329772000] java.lang.Thread.State: WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x000000076abc0630> (a java.util.concurrent.Semaphore$NonfairSync) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836) at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:997) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1304) at java.util.concurrent.Semaphore.acquire(Semaphore.java:312) at org.apache.uniffle.client.impl.DecompressionWorker.lambda$add$0(DecompressionWorker.java:102) at org.apache.uniffle.client.impl.DecompressionWorker$$Lambda$490/0x00000008006a0028.get(Unknown Source) at java.util.concurrent.CompletableFuture$AsyncSupply.run$$$capture(CompletableFuture.java:1604) at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:750) ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Needn't
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a github pipeline to run the tests of k8s
Why are the changes needed?
It can help us to verify the k8s patch
Does this PR introduce any user-facing change?
No
How was this patch tested?
No