Fix bug of "Comparison method violates its general contract" by zuston · Pull Request #315 · apache/uniffle · GitHub
Skip to content

Fix bug of "Comparison method violates its general contract"#315

Merged
roryqi merged 1 commit into
apache:masterfrom
zuston:compare
Nov 12, 2022
Merged

Fix bug of "Comparison method violates its general contract"#315
roryqi merged 1 commit into
apache:masterfrom
zuston:compare

Conversation

@zuston

@zuston zuston commented Nov 12, 2022

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Fix bug of "Comparison method violates its general contract"

Why are the changes needed?

If not, it will throw the exception when using the timsort.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Dont need

@zuston zuston requested review from kaijchen and roryqi November 12, 2022 07:43

@kaijchen kaijchen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston for the fix.

@codecov-commenter

codecov-commenter commented Nov 12, 2022

Copy link
Copy Markdown

@roryqi roryqi merged commit 4a3d2be into apache:master Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants