{{ message }}
[ISSUE-290] Make RpcNodePort and HttpNodePort optional#305
Merged
roryqi merged 2 commits intoNov 7, 2022
Merged
Conversation
3 tasks
Author
zuston
previously approved these changes
Nov 7, 2022
Contributor
|
We only provide the default value in the configuration. https://github.com/apache/incubator-uniffle/blob/master/conf/server.conf and https://github.com/apache/incubator-uniffle/blob/master/conf/coordinator.conf
|
Author
|
I see it better now. Made a change to have the default value in config entries match the values in the provided config file. |
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=========================================
Coverage 60.70% 60.70%
Complexity 1459 1459
=========================================
Files 180 180
Lines 9223 9223
Branches 886 886
=========================================
Hits 5599 5599
Misses 3325 3325
Partials 299 299
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roryqi
approved these changes
Nov 7, 2022
roryqi
left a comment
roryqi
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @amaliujia @zuston
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes
RPC_SERVER_PORTandJETTY_HTTP_PORTin RSS conf as optional by setting up default values into the config entries.Why are the changes needed?
Feature.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
UT