[MINOR] Fix flaky test by roryqi · Pull Request #238 · apache/uniffle · GitHub
Skip to content

[MINOR] Fix flaky test#238

Merged
roryqi merged 1 commit into
apache:masterfrom
roryqi:version
Sep 23, 2022
Merged

[MINOR] Fix flaky test#238
roryqi merged 1 commit into
apache:masterfrom
roryqi:version

Conversation

@roryqi

@roryqi roryqi commented Sep 22, 2022

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

org.apache.uniffle.test.GetShuffleReportForMultiPartTest is flaky
throws Exception:
ava.lang.ClassCastException: org.apache.spark.shuffle.RssShuffleManager cannot be cast to org.apache.uniffle.test.GetShuffleReportForMultiPartTest$RssShuffleManagerWrapper
at org.apache.uniffle.test.GetShuffleReportForMultiPartTest.runTest(GetShuffleReportForMultiPartTest.java:180)
at org.apache.uniffle.test.SparkIntegrationTestBase.runSparkApp(SparkIntegrationTestBase.java:74)
at org.apache.uniffle.test.SparkIntegrationTestBase.run(SparkIntegrationTestBase.java:52)
at org.apache.uniffle.test.GetShuffleReportForMultiPartTest.resultCompareTest(GetShuffleReportForMultiPartTest.java:141)

Why are the changes needed?

Fix flaky test

Does this PR introduce any user-facing change?

No

How was this patch tested?

GA passed

@codecov-commenter

Copy link
Copy Markdown

@roryqi roryqi requested a review from frankliee September 23, 2022 02:10
@roryqi roryqi merged commit d680a0c into apache:master Sep 23, 2022
roryqi added a commit that referenced this pull request Oct 12, 2022
### What changes were proposed in this pull request?
`org.apache.uniffle.test.GetShuffleReportForMultiPartTest` is flaky
 throws Exception:
ava.lang.ClassCastException: org.apache.spark.shuffle.RssShuffleManager cannot be cast to org.apache.uniffle.test.GetShuffleReportForMultiPartTest$RssShuffleManagerWrapper
	at org.apache.uniffle.test.GetShuffleReportForMultiPartTest.runTest(GetShuffleReportForMultiPartTest.java:180)
	at org.apache.uniffle.test.SparkIntegrationTestBase.runSparkApp(SparkIntegrationTestBase.java:74)
	at org.apache.uniffle.test.SparkIntegrationTestBase.run(SparkIntegrationTestBase.java:52)
	at org.apache.uniffle.test.GetShuffleReportForMultiPartTest.resultCompareTest(GetShuffleReportForMultiPartTest.java:141)

### Why are the changes needed?
Fix flaky test


### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
GA passed

Co-authored-by: roryqi <roryqi@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants