Support cancelling previous ci actions by zuston · Pull Request #225 · apache/uniffle · GitHub
Skip to content

Support cancelling previous ci actions#225

Merged
roryqi merged 3 commits into
apache:masterfrom
zuston:patch-1
Sep 19, 2022
Merged

Support cancelling previous ci actions#225
roryqi merged 3 commits into
apache:masterfrom
zuston:patch-1

Conversation

@zuston

@zuston zuston commented Sep 16, 2022

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Support cancelling previous ci actions when new commits are submitted.

Why are the changes needed?

I hope the CI actions can always test the latest commits code and cancel the previous ci when new commits are submitted.

Refer to: https://stackoverflow.com/questions/66335225/how-to-cancel-previous-runs-in-the-pr-when-you-push-new-commitsupdate-the-curre

Does this PR introduce any user-facing change?

How was this patch tested?

@zuston

zuston commented Sep 16, 2022

Copy link
Copy Markdown
Member Author

@kaijchen

Copy link
Copy Markdown
Member

@kaijchen Could u help check this feature? I dont know how to check its effect

Can you try push new empty commits in this PR?

@kaijchen

Copy link
Copy Markdown
Member

For reference, this works in Apache Ozone

concurrency:
  group: ci-${{ github.event.pull_request.number || github.sha }}
  cancel-in-progress: ${{ github.event_name == 'pull_request' }}

@zuston

zuston commented Sep 16, 2022

Copy link
Copy Markdown
Member Author

@kaijchen Could u help check this feature? I dont know how to check its effect

Can you try push new empty commits in this PR?

It works.

Comment thread .github/workflows/build.yml Outdated
@kaijchen

Copy link
Copy Markdown
Member

It works.

Great.

I think it's better to wait all CI on master to finish.
So we know where it starts to fail when something goes wrong.

Co-authored-by: Kaijie Chen <ckj@apache.org>
@zuston

zuston commented Sep 16, 2022

Copy link
Copy Markdown
Member Author

It works.

Great.

I think it's better to wait all CI on master to finish. So we know where it starts to fail when something goes wrong.

Make sense.

@kaijchen kaijchen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston.

There is one extra blank line, nevermind.

@codecov-commenter

codecov-commenter commented Sep 16, 2022

Copy link
Copy Markdown

@roryqi roryqi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston @kaijchen

@roryqi roryqi merged commit 9f6b3e5 into apache:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants