{{ message }}
Adjust the memory required times to match grpc max deadline conf#218
Merged
Conversation
Contributor
|
Like discussion at dev mail list, we will freeze the code and cut 0.6 version branch in September 15, we will not merge this pr before I cut 0.6 version branch, are you ok? |
Member
Author
|
PTAL @jerqi |
Contributor
|
I can't get the point. Could you give me more explanation? |
Member
Author
|
Now the require-memory retry threshold time > 60s in shuffle-server and the client grpc request max-time is 60s, it means that when the shuffle -shuffle memory is tight and the request time reached the 60s, the client side only will show the request timeout exception instead of requiring memory failed log. |
Contributor
roryqi
approved these changes
Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adjust the memory required times from 100 to 50 to match the grpc max deadline conf (60s).
Why are the changes needed?
If the required memory retry time > 60s, the client will cancel the request. That means the required memory exception wont throw to client side. And the server side wont show any related log.
Does this PR introduce any user-facing change?
No
How was this patch tested?