[MINOR] fix(test): fix flaky test ShuffleServerOnRandomPortTest by xianjingfeng · Pull Request #1953 · apache/uniffle · GitHub
Skip to content

[MINOR] fix(test): fix flaky test ShuffleServerOnRandomPortTest#1953

Merged
xianjingfeng merged 1 commit into
apache:masterfrom
xianjingfeng:flaky_test
Jul 25, 2024
Merged

[MINOR] fix(test): fix flaky test ShuffleServerOnRandomPortTest#1953
xianjingfeng merged 1 commit into
apache:masterfrom
xianjingfeng:flaky_test

Conversation

@xianjingfeng

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Fix flaky test ShuffleServerOnRandomPortTest.

Why are the changes needed?

The random port may be 40000.
https://github.com/apache/incubator-uniffle/actions/runs/10087508746/job/27891800095?pr=1952

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI

@xianjingfeng

Copy link
Copy Markdown
Member Author

@xianjingfeng xianjingfeng requested a review from rickyma July 25, 2024 03:43

@rickyma rickyma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xumanbu

xumanbu commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

LGTM.

@github-actions

github-actions Bot commented Jul 25, 2024

Copy link
Copy Markdown

Test Results

 2 732 files  +1   2 732 suites  +1   5h 38m 43s ⏱️ +23s
   969 tests ±0     968 ✅ +1   1 💤 ±0  0 ❌  - 1 
12 144 runs  +1  12 129 ✅ +2  15 💤 ±0  0 ❌  - 1 

Results for commit ea2d047. ± Comparison against base commit 5ddcc28.

♻️ This comment has been updated with latest results.

@xianjingfeng xianjingfeng merged commit c3d8a80 into apache:master Jul 25, 2024
@xianjingfeng xianjingfeng deleted the flaky_test branch July 25, 2024 09:05
@xianjingfeng

Copy link
Copy Markdown
Member Author

maobaolong pushed a commit to maobaolong/incubator-uniffle that referenced this pull request Aug 6, 2024
…he#1953)

### What changes were proposed in this pull request?
Fix flaky test ShuffleServerOnRandomPortTest.

### Why are the changes needed?
The random port may be 40000.
https://github.com/apache/incubator-uniffle/actions/runs/10087508746/job/27891800095?pr=1952

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
CI
zhengchenyu pushed a commit that referenced this pull request Aug 9, 2024
### What changes were proposed in this pull request?
Fix flaky test ShuffleServerOnRandomPortTest.

### Why are the changes needed?
The random port may be 40000.
https://github.com/apache/incubator-uniffle/actions/runs/10087508746/job/27891800095?pr=1952

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants