{{ message }}
[MINOR] fix(test): fix flaky test ServletTest.testUnhealthyNodesServlet#1952
Merged
Conversation
Member
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1952 +/- ##
============================================
- Coverage 52.77% 52.51% -0.26%
- Complexity 2498 2551 +53
============================================
Files 398 411 +13
Lines 18135 18771 +636
Branches 1660 1705 +45
============================================
+ Hits 9570 9857 +287
- Misses 7981 8297 +316
- Partials 584 617 +33 ☔ View full report in Codecov by Sentry. |
Contributor
Why are there three elements? |
advancedxy
reviewed
Jul 25, 2024
| shuffleServer3.markUnhealthy(); | ||
| shuffleServer4.markUnhealthy(); | ||
| List<String> expectShuffleIds = Arrays.asList(shuffleServer3.getId(), shuffleServer4.getId()); | ||
| List<String> shuffleIds = new ArrayList<>(); |
Contributor
There was a problem hiding this comment.
hmm.
I think you should move this initialization to the until lambda in Awaitility.
Member
Author
When the shuffle server becomes unhealthy, we need to wait for it to report its status to the coordinator before we can get its status from the coordinator. So sometimes only one unhealthy node will be obtained for the first time. |
advancedxy
approved these changes
Jul 25, 2024
Member
Author
maobaolong
pushed a commit
to maobaolong/incubator-uniffle
that referenced
this pull request
Aug 6, 2024
…et (apache#1952) ### What changes were proposed in this pull request? Fix flaky test ServletTest.testUnhealthyNodesServlet. ### Why are the changes needed? In the original logic, shuffleIds will have three elements when only one unhealthy node is obtained for the first time. https://github.com/apache/incubator-uniffle/actions/runs/10086923444/job/27890257649?pr=1948 ### Does this PR introduce any user-facing change? No. ### How was this patch tested? CI
zhengchenyu
pushed a commit
that referenced
this pull request
Aug 9, 2024
…et (#1952) ### What changes were proposed in this pull request? Fix flaky test ServletTest.testUnhealthyNodesServlet. ### Why are the changes needed? In the original logic, shuffleIds will have three elements when only one unhealthy node is obtained for the first time. https://github.com/apache/incubator-uniffle/actions/runs/10086923444/job/27890257649?pr=1948 ### Does this PR introduce any user-facing change? No. ### How was this patch tested? CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix flaky test ServletTest.testUnhealthyNodesServlet.
Why are the changes needed?
In the original logic,
shuffleIdswill have three elements when only one unhealthy node is obtained for the first time.https://github.com/apache/incubator-uniffle/actions/runs/10086923444/job/27890257649?pr=1948
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI