[#1910] fix: Remove the method name from the log by zuston · Pull Request #1911 · apache/uniffle · GitHub
Skip to content

[#1910] fix: Remove the method name from the log#1911

Merged
zuston merged 1 commit into
masterfrom
zuston-patch-2
Jul 17, 2024
Merged

[#1910] fix: Remove the method name from the log#1911
zuston merged 1 commit into
masterfrom
zuston-patch-2

Conversation

@zuston

@zuston zuston commented Jul 16, 2024

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

From the log4j document, we should not print out the method name into the log4j properties.

Why are the changes needed?

Fix: #1910

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Needn't

@zuston

zuston commented Jul 16, 2024

Copy link
Copy Markdown
Member Author

@github-actions

Copy link
Copy Markdown

Test Results

 2 657 files  ±0   2 657 suites  ±0   5h 32m 49s ⏱️ +22s
   946 tests ±0     945 ✅ ±0   1 💤 ±0  0 ❌ ±0 
11 799 runs  ±0  11 784 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit 93151aa. ± Comparison against base commit 64890eb.

@rickyma

rickyma commented Jul 16, 2024

Copy link
Copy Markdown
Contributor

This is not from log4j2. I don't think log4j2 will hang.

@zuston

zuston commented Jul 16, 2024

Copy link
Copy Markdown
Member Author

This is not from log4j2. I don't think log4j2 will hang.

Is this right? I'm not sure. Please see https://logging.apache.org/log4j/2.x/performance.html#asynchronous-logging-with-caller-location-information

@rickyma

rickyma commented Jul 16, 2024

Copy link
Copy Markdown
Contributor

Your jstack log does tell it's from log4j2. Instead, it should belong to log4j1.

@rickyma

rickyma commented Jul 16, 2024

Copy link
Copy Markdown
Contributor

We don't need the slf4j-reload4j dependency, we can remove it. That's probably the reason why it hangs.

@zuston

zuston commented Jul 16, 2024

Copy link
Copy Markdown
Member Author

Yes. I know this cause that not happen on the log4j2. But the doc indicates that we should not use the Method in the log style

@rickyma

rickyma commented Jul 16, 2024

Copy link
Copy Markdown
Contributor

We can remove it. When debuging, we can add it back manually.

Or we could just add something like a debug switch, then we can use different log4j2 configurations in different scenarios (test/prod).

@zuston

zuston commented Jul 16, 2024

Copy link
Copy Markdown
Member Author

We can remove it. When debuging, we can add it back manually.

Or we could just add something like a debug switch, then we can use different log4j2 configurations in different scenarios (test/prod).

Ok for me. I just hope the example log4j xml could be stable and available

@zuston zuston requested a review from rickyma July 16, 2024 11:52

@rickyma rickyma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickyma

rickyma commented Jul 16, 2024

Copy link
Copy Markdown
Contributor

@zuston zuston merged commit bb1eaa2 into master Jul 17, 2024
@roryqi roryqi deleted the zuston-patch-2 branch July 17, 2024 01:57
zhengchenyu pushed a commit that referenced this pull request Aug 9, 2024
### What changes were proposed in this pull request?

From the log4j document, we should not print out the method name into the log4j properties.

### Why are the changes needed?

Fix: #1910

Refer to: https://logging.apache.org/log4j/2.x/performance.html#asynchronous-logging-with-caller-location-information

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Needn't
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Shuffle server hang due to log4j callAppenders

2 participants