[MINOR] Improvement(dashboard): Support display human-readable time format for app page by maobaolong · Pull Request #1851 · apache/uniffle · GitHub
Skip to content

[MINOR] Improvement(dashboard): Support display human-readable time format for app page#1851

Merged
xianjingfeng merged 3 commits into
apache:masterfrom
maobaolong:improveAppPageTime
Jul 3, 2024
Merged

[MINOR] Improvement(dashboard): Support display human-readable time format for app page#1851
xianjingfeng merged 3 commits into
apache:masterfrom
maobaolong:improveAppPageTime

Conversation

@maobaolong

@maobaolong maobaolong commented Jul 2, 2024

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Display the human-readable time format in application page.

Why are the changes needed?

A long type timestamp really hard to get information from it.

Does this PR introduce any user-facing change?

Format the update time to human-readable.

How was this patch tested?

image

@rickyma

rickyma commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

Comment thread dashboard/src/main/webapp/src/pages/ApplicationPage.vue Outdated
Comment thread dashboard/src/main/webapp/src/pages/ApplicationPage.vue Outdated
@github-actions

github-actions Bot commented Jul 2, 2024

Copy link
Copy Markdown

Test Results

 2 657 files  ±0   2 657 suites  ±0   5h 31m 12s ⏱️ -16s
   946 tests ±0     945 ✅ ±0   1 💤 ±0  0 ❌ ±0 
11 789 runs  ±0  11 774 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit a770708. ± Comparison against base commit 441fad0.

♻️ This comment has been updated with latest results.

maobaolong and others added 2 commits July 2, 2024 18:35
Co-authored-by: xianjingfeng <xianjingfeng666@gmail.com>
Co-authored-by: xianjingfeng <xianjingfeng666@gmail.com>
@maobaolong

Copy link
Copy Markdown
Member Author

@xianjingfeng Thanks for you suggestion commit, I've accepted all of them, PTAL.

@xianjingfeng xianjingfeng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickyma rickyma requested a review from xianjingfeng July 2, 2024 13:04
@rickyma

rickyma commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

@xianjingfeng Please approve it.

@rickyma

rickyma commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

@maobaolong Please delete the auto-generated info like (Please outline the changes and how this PR fixes the issue.) in the description. Thanks.

@maobaolong

Copy link
Copy Markdown
Member Author

@xianjingfeng xianjingfeng merged commit 88152e9 into apache:master Jul 3, 2024
maobaolong added a commit to maobaolong/incubator-uniffle that referenced this pull request Aug 3, 2024
…ormat for app page (apache#1851)

Display the human-readable time format in application page.

A long type timestamp really hard to get information from it.

Format the update time to human-readable.

Manual testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants