{{ message }}
[#1743] fix: Add exception handling for thread pools#1744
Merged
Conversation
Contributor
Author
|
@zuston @jerqi PTAL. |
zuston
reviewed
May 29, 2024
zuston
left a comment
zuston
left a comment
Member
There was a problem hiding this comment.
If exception happens in the closures, the execution exception will be thrown
Contributor
Author
|
At least from the tests I've conducted, no exceptions have been thrown out. |
zuston
reviewed
May 30, 2024
Member
There was a problem hiding this comment.
This should not be covered, because it is wrapped by the CompletableFutureExtension, and then exception will be thrown
zhengchenyu
pushed a commit
that referenced
this pull request
Aug 2, 2024
### What changes were proposed in this pull request? Add exception handling for thread pools. ### Why are the changes needed? Fix: #1743. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add exception handling for thread pools.
Why are the changes needed?
Fix: #1743.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.