[#1476] feat(rust): Provide dedicated unregister app rpc for rust based server by zuston · Pull Request #1511 · apache/uniffle · GitHub
Skip to content

[#1476] feat(rust): Provide dedicated unregister app rpc for rust based server#1511

Merged
zuston merged 1 commit into
apache:masterfrom
zuston:addUnregisterAppRpc
Feb 9, 2024
Merged

[#1476] feat(rust): Provide dedicated unregister app rpc for rust based server#1511
zuston merged 1 commit into
apache:masterfrom
zuston:addUnregisterAppRpc

Conversation

@zuston

@zuston zuston commented Feb 8, 2024

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Provide dedicated unregister app rpc interface for rust based server

Why are the changes needed?

Fix: #1476

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

@zuston zuston requested a review from roryqi February 8, 2024 01:54
@codecov-commenter

codecov-commenter commented Feb 8, 2024

Copy link
Copy Markdown

@zuston

zuston commented Feb 8, 2024

Copy link
Copy Markdown
Member Author

cc @somelovelanguage

@github-actions

github-actions Bot commented Feb 8, 2024

Copy link
Copy Markdown

Test Results

2 287 files  +13  2 287 suites  +13   4h 26m 59s ⏱️ + 12m 57s
  819 tests ± 0    818 ✅ +44   1 💤 ±0  0 ❌  - 5 
9 086 runs  +17  9 073 ✅ +61  13 💤 ±0  0 ❌  - 5 

Results for commit c082ce3. ± Comparison against base commit 9471cba.

@roryqi roryqi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you reuse the same proto file?

@zuston

zuston commented Feb 8, 2024

Copy link
Copy Markdown
Member Author

@zuston zuston merged commit f6d1e7a into apache:master Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Provide dedicated unregister app rpc interface

3 participants