It seems that ut fail becuase rss.server.app.expired.withoutHeartbeat was set too small

Should we modify the value of rss.server.app.expired.withoutHeartbeat in all ut? @jerqi

Should we modify the value of rss.server.app.expired.withoutHeartbeat in all ut? @jerqi

Could you just modify the rpc timeout configuration to solve this problem?

Should we modify the value of rss.server.app.expired.withoutHeartbeat in all ut? @jerqi

Could you just modify the rpc timeout configuration to solve this problem?

This ut not fail every time, it is affected by host load. Maybe it will be normal to run again

Should we modify the value of rss.server.app.expired.withoutHeartbeat in all ut? @jerqi

Could you just modify the rpc timeout configuration to solve this problem?

This ut not fail every time, it is affected by host load. Maybe it will be normal to run again

You can trigger the test when you close the pr and reopen the pr again. According to my experience, the test won't be flaky test, if there are multiple failure pipelines.

cc @colinmjj

Error: writeTest Time elapsed: 51.138 s <<< FAILURE! org.opentest4j.AssertionFailedError: Unexpected flush process at org.apache.uniffle.server.ShuffleFlushManagerTest.waitForFlush(ShuffleFlushManagerTest.java:315) at org.apache.uniffle.server.ShuffleFlushManagerTest.writeTest(ShuffleFlushManagerTest.java:123)
Maybe something's wrong with CI ? @jerqi

Error: writeTest Time elapsed: 51.138 s <<< FAILURE! org.opentest4j.AssertionFailedError: Unexpected flush process at org.apache.uniffle.server.ShuffleFlushManagerTest.waitForFlush(ShuffleFlushManagerTest.java:315) at org.apache.uniffle.server.ShuffleFlushManagerTest.writeTest(ShuffleFlushManagerTest.java:123) Maybe something's wrong with CI ? @jerqi

It's a flaky test. If you rerun, it will succeed.

If you want to see the log, you can download https://github.com/apache/incubator-uniffle/actions/runs/2779258464

I can't see the contents like this. I just can see simple maven log.

I can't see the contents like this. I just can see simple maven log.

Click the link that I give you, and search Artifacts

Artifacts

I found it, thanks

Codecov Report

Merging #113 (561d557) into master (deb7fe4) will increase coverage by 0.59%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #113      +/-   ##
============================================
+ Coverage     56.52%   57.11%   +0.59%     
- Complexity     1183     1199      +16     
============================================
  Files           149      150       +1     
  Lines          8019     8176     +157     
  Branches        767      773       +6     
============================================
+ Hits           4533     4670     +137     
- Misses         3242     3259      +17     
- Partials        244      247       +3     

Help us with your feedback. Take ten seconds to tell us how you rate us.

LGTM @colinmjj Do you have any other suggestion?

+1, LGTM