{{ message }}
This repository was archived by the owner on Nov 24, 2025. It is now read-only.
TO: Only display Server ILO/XMPP Passwords Based on New Permission#7697
Merged
Conversation
shamrickus
added
bug
Member
|
@shamrickus can you also create the SECURE-SERVER:READ permission via a database migration? |
Member
|
@shamrickus is there a reason this can't be "fixed" in api v3 and v4? i know we don't like to change behavior of a published api but fixing a bug seems like it would be fair game. |
Member
Author
API v3 doesn't have the new role based permissions and this fixes it in v4. |
Member
kdamichie
approved these changes
Aug 8, 2023
kdamichie
left a comment
kdamichie
left a comment
Contributor
There was a problem hiding this comment.
Code looks good, and tested functionality
cybertunnel
pushed a commit
to cybertunnel/trafficcontrol
that referenced
this pull request
Aug 16, 2023
…pache#7697) * Remove priv checks for secure server fields * Handle api version 4 also * Forgot a file + changelog --------- Co-authored-by: Steve Hamrick <shamrick@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
serversendpoints will display thexmppPasswd/iloPasswordbased only on privlevel. In api v5/v4 this has been changed to check for a new permissionSECURE-SERVER:READinstead (if enabled).Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Confirm the TO Tests work. For version api version 3/4 and
role_based_permissionsis off confirm that Ops/Admin PrivLevel is required to view the two password fields. For Version 4, confirm that withrole_based_permissionsset, that only users that are admin or have theSECURE-SERVER:READpermission can view the password fields. For version 5, it should only check for the permission.If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist