[SYSTEMDS-3681] Add stepGLM builtin function. by Bruno-Ignaz · Pull Request #2523 · apache/systemds · GitHub
Skip to content

[SYSTEMDS-3681] Add stepGLM builtin function.#2523

Open
Bruno-Ignaz wants to merge 10 commits into
apache:mainfrom
Bruno-Ignaz:main
Open

[SYSTEMDS-3681] Add stepGLM builtin function.#2523
Bruno-Ignaz wants to merge 10 commits into
apache:mainfrom
Bruno-Ignaz:main

Conversation

@Bruno-Ignaz

Copy link
Copy Markdown

Hi,
This is a homework pull-requests for the course AMLs at TUB.
This is also my first pull-request :)

I refactored ./scripts/algorithm/StepGLM.dml into a importable function.

  • Over 900 lines of code removed
  • Replacement of global variables with function parameters
  • Replacement of custom GLM solver glm_fit with adapter that uses the builtin solver m_gml from ./scripts/builtin/gml.dml
  • Rewrite of the AIC calculation.

The probit inverse link function is now approximated (AIC calculation):

"it does not matter much whether one uses a probit model or a logit model, except in cases where data are heavily concentrated in the tails" (page 1487 in [1])

Additionally:

  • ./scripts/algorithms/TestBuiltinStepGLM.dml performs two checks for function output.

Sources

[1]: Takeshi, Qualitative Response Models: A Survey (1981)

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant