{{ message }}
Migrate from Storm-shaded Commons Lang to Commons Lang 3#1835
Merged
Conversation
rzo1
commented
Mar 22, 2026
rzo1
commented
Contributor
- Replace org.apache.storm.shade.org.apache.commons.lang.StringUtils with org.apache.commons.lang3.StringUtils in core, opensearch, and solr modules
- Prepares for upcoming Storm release which will drop the shaded Commons Lang 2
- commons-lang3 was already a declared dependency in core; external modules receive it transitively
- All usages (isBlank, isNotBlank) are API-compatible between lang2 and lang3
…dn'T use the shaded dependency in SC anyway.
rzo1
requested review from
jnioche,
mvolikas,
sebastian-nagel,
sigee and
tballison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.