#1246 - Make ProxyManager to return optional incase no proxy is used by quangdutran · Pull Request #1532 · apache/stormcrawler · GitHub
Skip to content

#1246 - Make ProxyManager to return optional incase no proxy is used#1532

Merged
rzo1 merged 1 commit into
apache:mainfrom
quangdutran:issue-1246
Jun 16, 2025
Merged

#1246 - Make ProxyManager to return optional incase no proxy is used#1532
rzo1 merged 1 commit into
apache:mainfrom
quangdutran:issue-1246

Conversation

@quangdutran

Copy link
Copy Markdown
Contributor

Thank you for contributing to Apache StormCrawler.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes

  • Is there a issue associated with this PR? Is it referenced in the commit message?

  • Does your PR title start with #XXXX where XXXX is the issue number you are trying to resolve?

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

  • Is the code properly formatted with mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false?

For code changes

  • Have you ensured that the full suite of tests is executed via mvn clean verify?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file?

Note

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@rzo1 rzo1 requested review from jnioche and tballison May 13, 2025 08:19
@rzo1 rzo1 added this to the 3.3.1 milestone May 13, 2025
@rzo1

rzo1 commented May 13, 2025

Copy link
Copy Markdown
Contributor

@rzo1

rzo1 commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

@rzo1 rzo1 merged commit 97efd53 into apache:main Jun 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants