Detect multi addresses separated by ; in a single String. Fixes #1382 by jnioche · Pull Request #1387 · apache/stormcrawler · GitHub
Skip to content

Detect multi addresses separated by ; in a single String. Fixes #1382#1387

Merged
rzo1 merged 2 commits into
mainfrom
1382
Nov 3, 2024
Merged

Detect multi addresses separated by ; in a single String. Fixes #1382#1387
rzo1 merged 2 commits into
mainfrom
1382

Conversation

@jnioche

@jnioche jnioche commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

Thank you for contributing to Apache StormCrawler.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • [ x] Is there a issue associated with this PR? Is it referenced in the commit message?

  • [ x] Does your PR title start with #XXXX where XXXX is the issue number you are trying to resolve?

  • [ x] Has your PR been rebased against the latest commit within the target branch (typically main)?

  • [ x] Is your initial contribution a single, squashed commit?

  • [ x] Is the code properly formatted with mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false?

For code changes:

  • [ x] Have you ensured that the full suite of tests is executed via mvn clean verify?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

Signed-off-by: Julien Nioche <julien@digitalpebble.com>
@jnioche jnioche added this to the 3.1.1 milestone Nov 1, 2024
@rzo1 rzo1 merged commit a2c84b9 into main Nov 3, 2024
@rzo1 rzo1 deleted the 1382 branch November 3, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants