#1301 - add build doc for the source release by rzo1 · Pull Request #1383 · apache/stormcrawler · GitHub
Skip to content

#1301 - add build doc for the source release#1383

Merged
jnioche merged 1 commit into
mainfrom
add-build-doc-for-the-source-release-#1301
Oct 30, 2024
Merged

#1301 - add build doc for the source release#1383
jnioche merged 1 commit into
mainfrom
add-build-doc-for-the-source-release-#1301

Conversation

@rzo1

@rzo1 rzo1 commented Oct 30, 2024

Copy link
Copy Markdown
Contributor

Thank you for contributing to Apache StormCrawler.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a issue associated with this PR? Is it referenced in the commit message?

  • Does your PR title start with #XXXX where XXXX is the issue number you are trying to resolve?

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

  • Is the code properly formatted with mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean verify?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@rzo1 rzo1 requested a review from jnioche October 30, 2024 06:05
@rzo1 rzo1 self-assigned this Oct 30, 2024
@rzo1 rzo1 added this to the 3.1.1 milestone Oct 30, 2024
@jnioche jnioche merged commit 1c0e33c into main Oct 30, 2024
@jnioche jnioche deleted the add-build-doc-for-the-source-release-#1301 branch October 30, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants