Aligned version of OpenSearch in test with recent upgrade to 2.16 by jnioche · Pull Request #1293 · apache/stormcrawler · GitHub
Skip to content

Aligned version of OpenSearch in test with recent upgrade to 2.16#1293

Merged
rzo1 merged 1 commit into
mainfrom
opensearch2.16
Sep 11, 2024
Merged

Aligned version of OpenSearch in test with recent upgrade to 2.16#1293
rzo1 merged 1 commit into
mainfrom
opensearch2.16

Conversation

@jnioche

@jnioche jnioche commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

Thank you for contributing to Apache StormCrawler.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a issue associated with this PR? Is it referenced in the commit message?

  • Does your PR title start with #XXXX where XXXX is the issue number you are trying to resolve?

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

  • Is the code properly formatted with mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean verify?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

Signed-off-by: Julien Nioche <julien@digitalpebble.com>
@jnioche jnioche added this to the 3.1.0 milestone Sep 11, 2024
@rzo1 rzo1 merged commit 9322213 into main Sep 11, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to set this via an env variable one day, which is populated via mvn surefire, so it picks up automated changes.

@rzo1 rzo1 deleted the opensearch2.16 branch September 11, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants