Fix #1290 "Add close/cleanup method to ParseFilters" by rzo1 · Pull Request #1291 · apache/stormcrawler · GitHub
Skip to content

Fix #1290 "Add close/cleanup method to ParseFilters"#1291

Merged
jnioche merged 1 commit into
mainfrom
1290
Sep 10, 2024
Merged

Fix #1290 "Add close/cleanup method to ParseFilters"#1291
jnioche merged 1 commit into
mainfrom
1290

Conversation

@rzo1

@rzo1 rzo1 commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

Thank you for contributing to Apache StormCrawler.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a issue associated with this PR? Is it referenced in the commit message?

  • Does your PR title start with #XXXX where XXXX is the issue number you are trying to resolve?

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

  • Is the code properly formatted with mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean verify?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@rzo1 rzo1 added this to the 3.1.0 milestone Sep 9, 2024
@jnioche jnioche merged commit 00d667c into main Sep 10, 2024
@rzo1 rzo1 deleted the 1290 branch September 11, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants