Fix #1244 "Migrate to JUnit 5" by rzo1 · Pull Request #1245 · apache/stormcrawler · GitHub
Skip to content

Fix #1244 "Migrate to JUnit 5"#1245

Merged
jnioche merged 1 commit into
mainfrom
junit5
Jun 21, 2024
Merged

Fix #1244 "Migrate to JUnit 5"#1245
jnioche merged 1 commit into
mainfrom
junit5

Conversation

@rzo1

@rzo1 rzo1 commented Jun 18, 2024

Copy link
Copy Markdown
Contributor

For all changes:

  • Is there a issue associated with this PR? Is it referenced in the commit message?

  • Does your PR title start with #XXXX where XXXX is the issue number you are trying to resolve?

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

  • Is the code properly formatted with mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean verify?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file?

Note:

Note: Tests were auto-converted via https://github.com/junit-pioneer/convert-junit4-to-junit5

Fix #1241 "Ensure SC can be build without a Docker environment"
@jnioche jnioche merged commit 5b77247 into main Jun 21, 2024
@jnioche jnioche deleted the junit5 branch June 21, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to JUnit 5 Ensure SC can be build without a Docker environment

2 participants