#1238 - Avoid use of star imports by rzo1 · Pull Request #1239 · apache/stormcrawler · GitHub
Skip to content

#1238 - Avoid use of star imports#1239

Merged
jnioche merged 2 commits into
mainfrom
Avoid-use-of-star-imports-#1238
May 21, 2024
Merged

#1238 - Avoid use of star imports#1239
jnioche merged 2 commits into
mainfrom
Avoid-use-of-star-imports-#1238

Conversation

@rzo1

@rzo1 rzo1 commented May 21, 2024

Copy link
Copy Markdown
Contributor

Thank you for contributing to Apache StormCrawler.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a issue associated with this PR? Is it referenced in the commit message?

  • Does your PR title start with #XXXX where XXXX is the issue number you are trying to resolve?

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

  • Is the code properly formatted with mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean verify?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@rzo1 rzo1 added this to the 3.1.0 milestone May 21, 2024
@rzo1 rzo1 requested a review from jnioche May 21, 2024 11:51
@rzo1 rzo1 self-assigned this May 21, 2024
@rzo1 rzo1 force-pushed the Avoid-use-of-star-imports-#1238 branch from 3518906 to 399ecb4 Compare May 21, 2024 12:02
Comment thread archetype/src/main/resources/archetype-resources/src/main/java/CrawlTopology.java Outdated
@rzo1 rzo1 force-pushed the Avoid-use-of-star-imports-#1238 branch from 399ecb4 to cf17dcb Compare May 21, 2024 12:40

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rzo1 did you check that the class is generated correctly when removing 'package'?

@jnioche jnioche merged commit b752301 into main May 21, 2024
@jnioche jnioche deleted the Avoid-use-of-star-imports-#1238 branch May 21, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants