{{ message }}
Issue #728: Adding asterisk for metadata transfer#1117
Merged
jnioche merged 3 commits intoNov 13, 2023
Conversation
Signed-off-by: Michael Dinzinger <michael.dinzinger@uni-passau.de>
jnioche
reviewed
Nov 6, 2023
jnioche
left a comment
jnioche
left a comment
Contributor
There was a problem hiding this comment.
Thanks! this would be very helpful. See comments on possible improvements
Signed-off-by: Michael Dinzinger <michael.dinzinger@uni-passau.de>
Contributor
…persist + transfer Signed-off-by: Michael Dinzinger <michael.dinzinger@uni-passau.de>
Contributor
Author
jnioche
approved these changes
Nov 13, 2023
jnioche
left a comment
jnioche
left a comment
Contributor
There was a problem hiding this comment.
Perfect! Thanks a lot @michaeldinzinger, this is a great addition to StormCrawler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello all
Goal:
When having a lot of metadata fields that all start with the same prefix, e.g.
parse.[...], one can simply writeinstead of listing them all.
Besides that, making mdToTransfer, mdToPersistOnly, trackPath and trackDepth protected instead of private. This makes it easier to create a Custom Metadata Transfer class.