Changes for Postgresql Copy Export: by RobertBHamilton · Pull Request #68 · apache/sqoop · GitHub
Skip to content
This repository was archived by the owner on Jul 9, 2021. It is now read-only.

Changes for Postgresql Copy Export: - #68

Open
RobertBHamilton wants to merge 3 commits into
apache:trunkfrom
RobertBHamilton:trunk
Open

RobertBHamilton wants to merge 3 commits into
apache:trunkfrom
RobertBHamilton:trunk

Conversation

@RobertBHamilton

Copy link
Copy Markdown
  1. Support for empty null string --null-string ''
  2. Support for non-xml delim --fields-terminated-by'\0x1c'
  3. Added line buffering perf --batch
  4. optional TEXT mode instead of CSV -Dpostgresql.format.text=true
  5. Support for postgres Version 8x -Dpostgresql.targetdb.ver=8
  6. Optional disable escape sequences -Dpostgresql.input.israw=true

 1. Support for empty null string        --null-string ''
 2. Support for non-xml delim            --fields-terminated-by'\0x1c'
 3. Added line buffering perf            --batch
 4. optional TEXT mode instead of CSV    -Dpostgresql.format.text=true
 5. Support for postgres Version 8       -Dpostgresql.targetdb.ver=8
 6. Optional disable escape sequences    -Dpostgresql.input.israw=true
@RobertBHamilton

Copy link
Copy Markdown
Author

Robert B Hamilton added 2 commits January 21, 2019 22:18
1. moved LineBuffer to inner class of the Export Mapper
2. extended support to 9.x direct copy
3. Added test case
@szvasas

szvasas commented Feb 1, 2019

Copy link
Copy Markdown
Contributor

Hi Robert,

Thanks for sharing these improvements!
As you described in your email it seems that there are a few different improvements covered in this PR so I would like to ask you to split these changes into separate patches and raise separate Sqoop issues for them on JIRA (https://issues.apache.org/jira/projects/SQOOP/issues).

I haven't done an in-depth review yet but I noticed that the indentation and the formatting you used is quite different from the surrounding code so please try to follow those conventions, e.g.:

  • Add spaces before and after '=' character (e.g. bufferMode = false instead of bufferMode=false)

  • The content of a block should go in a new line, e.g.

public void clear() {
  sb.setLength(0);
}

instead of
public void clear(){ sb.setLength(0); }

Apart from this I have seen a few commented out code lines, please remove those as well.

Regards,
Szabolcs

@Fokko

Fokko commented Mar 9, 2019

Copy link
Copy Markdown
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants