{{ message }}
Added github actions for basic build/test setup.#113
Merged
Conversation
mbien
commented
Dec 25, 2021
mbien
commented
Member
- builds/tests on JDK 11 and 17
- uploads junit report
- disabled a failing test for now
- runs on JDK 11 and 17 - reports test results
Member
Author
Member
Author
|
added step for selenium tests (didn't know that geckodriver could run headless). |
snoopdave
approved these changes
Dec 27, 2021
snoopdave
left a comment
snoopdave
left a comment
Contributor
There was a problem hiding this comment.
This looks very cool. I have not tried it out yet, but I see no reason not to merge.
Member
Author
|
awesome. I merge it, lets see if everything builds. |
Member
Author
|
it builds and tests but it didn't upload the test report (it should appear on the list on the left i think) Don't know why because I tested it on my wip branch and it worked fine. (but its not so important tbh, the full log is recorded anyway in case something fails) |
Member
Author
|
oh haha. It published it in he CodeQL action |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.