{{ message }}
RATIS-2581. Add pluggable file destroyer#1499
Open
HTHou wants to merge 1 commit into
Open
Conversation
HTHou
changed the title
HTHou
force-pushed
the
ratis-2581-file-destroyer
branch
3 times, most recently
from
b5117d0 to
cb7edeb
Compare
HTHou
force-pushed
the
ratis-2581-file-destroyer
branch
from
cb7edeb to
7bd1336
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a pluggable file destroyer for Ratis local storage cleanup paths.
The default destroyer preserves the existing behavior using regular filesystem delete and truncate operations. Embedders may install a custom destroyer through
FileUtilsso that Ratis-managed files can use the same destruction policy as the embedding system.This patch also routes several normal cleanup paths through
FileUtilsso they use the configured destroyer, including atomic output stream temporary-file cleanup, zero-size open log segment cleanup, recursive delete cleanup, and buffered log file truncation. Delete-on-exit paths remain on nativeFile.deleteOnExit()to preserve the JDK shutdown ordering semantics.https://issues.apache.org/jira/browse/RATIS-2581
How was this patch tested?
TestFileUtils#testRatisFileDestroyerHook.git diff --checkandgit diff --cached --check../mvnw -pl ratis-common -Dtest=TestFileUtils test../mvnw -pl ratis-server -am -DskipTests compile.