{{ message }}
feat: add batch reader infrastructure - #46
Merged
Conversation
leaves12138
approved these changes
Jun 4, 2026
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Reviewed PR #46 as an allowed intermediate step in the batch reader migration. The missing follow-up dependencies are expected to be added by later PRs, so they are not blockers for this staged split. I did not find other blockers. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

feat: add batch reader infrastructure
Changes
BatchReaderNextBatch()returningArrowArray+ArrowSchema, andNextBatchWithBitmap()returning batches with a validity bitmap for efficient deletion vector and index filtering. Provides EOF detection and reader metrics.FileBatchReaderBatchReaderfor single-file reading scenarios. AddsSetReadSchema()for dynamic schema/predicate reconfiguration,GetFileSchema(),GetPreviousBatchFirstRowNumber(),GetNumberOfRows(), andSupportPreciseBitmapSelection()for bitmap-based row selection.PrefetchFileBatchReaderFileBatchReaderwith prefetch capabilities.CompleteRowKindBatchReaderBatchReaderwrapper that prepends a_VALUE_KINDcolumn (int8 array ofRowKindvalues) to each output batch.ConcatBatchReaderBatchReaderinstances and reads them sequentially.DelegatingPrefetchReaderFileBatchReaderadapter that wraps aPrefetchFileBatchReaderImpl. Transparently delegates to the prefetch reader or its first underlying reader based on whether prefetching is needed.PredicateBatchReaderBatchReaderwrapper that applies aPredicatefilter to each batch.ReaderUtilsTests
CompleteRowKindBatchReaderTestConcatBatchReaderTestPredicateBatchReaderTestReaderUtilsTest