{{ message }}
feat: Migrate file index interfaces, format, reader, result, and factory - #45
Merged
Merged
Conversation
Member
Author
leaves12138
approved these changes
Jun 4, 2026
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Reviewed PR #45 as an intermediate step in the file-index migration. The missing bitmap/bloom-filter/bsi implementations are expected to be added by follow-up PRs, so that dependency gap is not a blocker for this staged split. I did not find other blockers in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Purpose
No Linked issue.
Migrate file index module public interfaces and core implementations:
File index interfaces (
include/paimon/file_index/):FileIndexFormat— file index serialization format with header, body, and column index entries (file_index_format.h)FileIndexResult— query result representing matched/unmatched row ranges (file_index_result.h)FileIndexReader— abstract reader for querying a file index (file_index_reader.h)BitmapIndexResult— bitmap-backed index query result (bitmap_index_result.h)FileIndexer— abstract file indexer producing readers and writers (file_indexer.h)FileIndexWriter— abstract writer for building a file index (file_index_writer.h)FileIndexerFactory— registry and factory for file indexer implementations (file_indexer_factory.h)File index implementation (
src/paimon/common/file_index/):FileIndexFormat— serialization/deserialization of file index format (file_index_format.cpp)FileIndexReader— base reader implementation with column dispatch (file_index_reader.cpp)FileIndexResult— result intersection, union, and row range operations (file_index_result.cpp)FileIndexerFactory— factory registration and lookup logic (file_indexer_factory.cpp)Empty index (
src/paimon/common/file_index/empty/):EmptyFileIndexReader— no-op reader returning all-match results (empty_file_index_reader.h)Tests
file_index_format_test.cpp— format round-trip serialization, multi-column index, edge casesfile_index_reader_test.cpp— reader column dispatch and empty index fallbackfile_index_result_test.cpp— result set operations (intersection, union)file_indexer_factory_test.cpp— factory registration and lookupempty_file_index_reader_test.cpp— empty reader always-match behaviorAPI and Format
Adds public file index interfaces under
include/paimon/file_index/. No storage format or protocol changes.Documentation
Generative AI tooling
Migrate-by: Aone Copilot (Claude)