{{ message }}
feat: Migrate format interfaces, column_stats, table special_fields, and lookup store - #43
Merged
Merged
Conversation
leaves12138
approved these changes
Jun 3, 2026
leaves12138
left a comment
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Reviewed PR #43. The migrated format interfaces, ColumnStats, special fields, and lookup store code are consistent with the existing Paimon C++ reference implementation, and I did not find blockers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
No Linked issue.
Migrate format module public interfaces, column_stats implementation, table/lookup utilities:
Format interfaces (
include/paimon/format/):ColumnStats— per-column min/max/null statistics (column_stats.h)FormatWriter— abstract format writer interface (format_writer.h)FormatStatsExtractor— extract column stats from format files (format_stats_extractor.h)WriterBuilder— builder for creating format writers (writer_builder.h)FileFormat— file format descriptor (file_format.h)FileFormatFactory— factory for registering/creating file formats (file_format_factory.h)ReaderBuilder— builder for creating format readers (reader_builder.h)Format implementation (
src/paimon/common/format/):ColumnStats— column stats merge, serialization, type-aware comparison (column_stats.cpp)FileFormatFactory— format factory registry implementation (file_format_factory.cpp)Table utilities (
src/paimon/common/table/):SpecialFields— well-known field definitions for system columns (special_fields.h)Lookup store (
src/paimon/common/lookup/):LookupStoreFactory— abstract factory for lookup store creation (lookup_store_factory.h/cpp)SortLookupStoreFactory— sorted-file based lookup store factory (sort/sort_lookup_store_factory.h/cpp)SortLookupStoreFooter— footer encoding/decoding for sorted lookup files (sort/sort_lookup_store_footer.h/cpp)Tests
column_stats_test.cpp— column stats merge, comparison, edge casesspecial_fields_test.cpp— special field definitions and lookupssort_lookup_store_test.cpp— sorted lookup store read/write and footer round-tripAPI and Format
Adds public format interfaces under
include/paimon/format/. No storage format or protocol changes.Documentation
Generative AI tooling
Migrate-by: Aone Copilot (Claude)