{{ message }}
feat: add search predicates and PredicateBuilder and tests - #36
Merged
Conversation
Member
Author
leaves12138
approved these changes
Jun 1, 2026
leaves12138
left a comment
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the latest head. The predicate builder/utils/validator, search predicate descriptors, and migrated predicate tests look good to me. I did not find blockers in this pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
No Linked issue.
Complete the predicate framework with builder, utilities, validation, and search predicates:
PredicateBuilder— fluent API to construct leaf/compound predicates against aRowType(predicate_builder.h/cpp)PredicateUtils— helpers for predicate transformation, splitting by And, and field extraction (predicate_utils.h/cpp)PredicateValidator— validates predicate field references and type compatibility (predicate_validator.h)FullTextSearch— full-text search predicate descriptor (full_text_search.h)VectorSearch— vector similarity search predicate descriptor (vector_search.h)Tests
predicate_test.cpp— end-to-end predicate construction and evaluation across all operatorspredicate_utils_test.cpp— predicate transformation and splittingpredicate_validator_test.cpp— field reference and type validationAPI and Format
New public headers under
include/paimon/predicate/(predicate_builder.h,predicate_utils.h,full_text_search.h,vector_search.h).Documentation
Generative AI tooling
Migrate-by: Aone Copilot (Claude)