feat(third-party): introduce roaring bitmap and xxhash - #34
Conversation
leaves12138
left a comment
leaves12138
left a comment
There was a problem hiding this comment.
Thanks for adding the vendored sources. I found one release-blocking licensing issue: third_party/roaring_bitmap/roaring.cpp includes a BSD-3-Clause block for code derived from PyTorch TH simd.h (Facebook/Idiap/DeepMind/NEC/NYU copyrights) around lines 15276-15318, but the current LICENSE entry only records CRoaring as Apache-2.0. For binary redistribution, BSD-3-Clause requires reproducing the copyright, conditions, and disclaimer in the documentation/materials, so please add this bundled third-party license/copyright text to LICENSE (and update NOTICE only if required by ASF policy). I did not find other blockers in this pass.
dbed40e to
451121f
Compare
leaves12138
left a comment
leaves12138
left a comment
There was a problem hiding this comment.
Re-reviewed the latest head. The previous licensing blocker is resolved: LICENSE now includes the BSD-3-Clause copyright, conditions, and disclaimer for the PyTorch TH simd.h-derived code embedded in CRoaring. I did not find other blockers in this pass.
2 participants
Purpose
Linked issue: None
Introduce vendored third-party sources for CRoaring and xxHash:
third_party/roaring_bitmap/.third_party/xxhash/.LICENSEandNOTICEfor the bundled third-party code.The original third-party source license headers are preserved. The top-level
LICENSEalso declares the BSD-3-Clause PyTorch THsimd.hderived code embedded inthird_party/roaring_bitmap/roaring.cpp. Only the local CMake wrapper files use ASF headers.Tests
git diff --checkgit diff --cached --checkcmake -S third_party/roaring_bitmap -B /tmp/paimon-cpp-roaring-buildcmake --build /tmp/paimon-cpp-roaring-build -j64cmake -S third_party/xxhash -B /tmp/paimon-cpp-xxhash-buildcmake --build /tmp/paimon-cpp-xxhash-build -j64API and Format
No public API, storage format, or protocol changes.
Documentation
No user-facing documentation changes. The repository-level
LICENSEandNOTICEfiles were updated for third-party declarations.Generative AI tooling
Migrate-by: OpenAI Codex