{{ message }}
feat: add predicate leaf functions - #33
Merged
Merged
Conversation
Member
Author
leaves12138
approved these changes
May 29, 2026
leaves12138
left a comment
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the updated predicate leaf function implementations. The LIKE matcher fix looks good, and the comparison, null, IN/NOT_IN, compound, and string predicate semantics match the Java behavior I checked. Given that tests and public construction entry points will be submitted in the follow-up PR to keep this one focused, I do not see blockers for this PR.
leaves12138
approved these changes
Jun 1, 2026
leaves12138
left a comment
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the latest head. The follow-up LIKE error formatting/emplace cleanup looks good, and I did not find new blockers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
No Linked issue.
Introduce concrete
LeafFunctionandCompoundFunctionimplementations for all predicate operators:Equal,NotEqual,GreaterThan,GreaterOrEqual,LessThan,LessOrEqualIn,NotInIsNull,IsNotNullAnd,OrLike,Contains,StartsWith,EndsWithEach operator provides
Test()overloads for per-row evaluation, batch (Arrow array) evaluation, and min/max stats-based file skipping.Tests
API and Format
Documentation
Generative AI tooling
Migrate-by: Aone Copilot (Claude)