{{ message }}
feat: add binary row serializers and blob implementation - #31
Merged
Conversation
leaves12138
requested changes
May 29, 2026
leaves12138
left a comment
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. I found two blockers that should be fixed before merge: one compile-time missing include and one moved-from unique_ptr dereference risk in Blob construction.
leaves12138
approved these changes
Jun 1, 2026
leaves12138
left a comment
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Re-reviewed the latest head. The Blob construction no longer uses the descriptor after moving it, so the unspecified argument evaluation issue is resolved. I am not treating the var_length_int_utils dependency as a blocker per the planned follow-up. I did not find other blockers in this pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce serialization infrastructure for Paimon's binary row format, including
BinaryRowSerializer,BinarySerializerUtils,RowCompactedSerializer, and theBlobimplementation.Changes
BinaryRowSerializerBinaryRowBinarySerializerUtilsInternalRow,InternalArray,InternalMapinto their binary counterparts (BinaryRow,BinaryArray,BinaryMap)RowCompactedSerializerInternalRow, using bitset-based null tracking and variable-length integer encodingSerializeToBytes()/Deserialize()for row-level serializationBlobBlobclass for managing blob descriptors and blob dataTests
BinaryRowSerializerTestBinarySerializerUtilsTestRowCompactedSerializerTest