{{ message }}
feat: migrate common/data/columnar module - #30
Closed
leaves12138 wants to merge 1 commit into
Closed
Conversation
This is an equivalent replacement for apache#24, rebased on current main after resolving the date_time_utils.h conflict introduced by recently merged utility changes.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for #24 because the original branch is dirty after #21/#22/#23 were merged and this maintainer token cannot push to the contributor fork.
The net change is the same columnar module from #24, applied on top of current
main; thedate_time_utils.hconflict was resolved by keeping the newer timezone helpers from #23 and retaining the timestamp helper APIs needed by the columnar code.Closes #24.