Improve logging for `LinkageError` scenarios involving the LMAX Disruptor library by ramanathan1504 · Pull Request #4124 · apache/logging-log4j2 · GitHub
Skip to content

Improve logging for LinkageError scenarios involving the LMAX Disruptor library#4124

Merged
vy merged 6 commits into
apache:2.xfrom
ramanathan1504:fix-log-disruptor-initialization-errors
May 29, 2026
Merged

Improve logging for LinkageError scenarios involving the LMAX Disruptor library#4124
vy merged 6 commits into
apache:2.xfrom
ramanathan1504:fix-log-disruptor-initialization-errors

Conversation

@ramanathan1504

@ramanathan1504 ramanathan1504 commented May 10, 2026

Copy link
Copy Markdown
Contributor

FIxes #2250

Reference URLs

What was done

-Improves user visibility by updating the logging message while keeping the existing initialization error handling behavior unchanged.

@vy vy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify logging

@vy vy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added defensive LinkageError handling in DisruptorUtil when creating async logger exception handlers.

I don't see that.

Guarded sequenceCallback.set(sequence) with a null check in RingBufferLogEventHandler4 to prevent NPE when callback is not initialized.

I don't see that either.

@github-project-automation github-project-automation Bot moved this from Approved to Changes requested in Log4j pull request tracker May 21, 2026
Comment thread log4j-core/src/main/java/org/apache/logging/log4j/core/async/DisruptorUtil.java Outdated
@ramanathan1504

ramanathan1504 commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

@vy vy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramanathan1504, would you mind adding a brief changelog entry, please?

I'd appreciate it if you can update the description of the PR to reflect the goal.

…nitialization to improve diagnostics and user visibility
@ramanathan1504

Copy link
Copy Markdown
Contributor Author

Comment thread src/changelog/.2.x.x/fix-log-disruptor-initialization-errors.xml Outdated
@vy vy changed the title Improve handling of LinkageErrors during LMAX Disruptor initializatio… Improve logging for LinkageError scenarios involving the LMAX Disruptor library May 29, 2026
@github-project-automation github-project-automation Bot moved this from Changes requested to Approved in Log4j pull request tracker May 29, 2026
@vy vy enabled auto-merge (squash) May 29, 2026 10:51
@vy vy merged commit 619debb into apache:2.x May 29, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Log4j pull request tracker May 29, 2026
vy pushed a commit that referenced this pull request Jun 1, 2026
@ramanathan1504 ramanathan1504 added this to the 2.27.0 milestone Jun 2, 2026
@ramanathan1504 ramanathan1504 modified the milestones: 2.27.0, 2.26.1 Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Log disruptor initialization errors

2 participants