Move Flume Appender to `logging-log4j-flume` repo by ppkarwasz · Pull Request #2902 · apache/logging-log4j2 · GitHub
Skip to content

Move Flume Appender to logging-log4j-flume repo#2902

Merged
ppkarwasz merged 3 commits into
2.xfrom
feature/2.x/move-flume
Aug 30, 2024
Merged

Move Flume Appender to logging-log4j-flume repo#2902
ppkarwasz merged 3 commits into
2.xfrom
feature/2.x/move-flume

Conversation

@ppkarwasz

Copy link
Copy Markdown
Member

The code of the Flume Appender has been moved to a new logging-log4j-flume.

This PR remove the log4j-flume-ng module from the repository and cleans up the dependency management section.

@ppkarwasz ppkarwasz added this to the 2.24.0 milestone Aug 30, 2024

@vy vy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume you did not update src/site due to the missing logging-log4j-flume website, right?

@ppkarwasz

Copy link
Copy Markdown
Member Author

@vy

vy commented Aug 30, 2024

Copy link
Copy Markdown
Member

I presume you did not update src/site due to the missing logging-log4j-flume website, right?

I think that the Flume Appender should be documented in the main site. We can create a stub /log4j/flume/2.x site later that only refers the user to the main site.

I prefer placing the docs next to the sources. This worked nicely for JMX GUI and Jakarta. Why do you think we need to create an exception for Flume?

@ppkarwasz

Copy link
Copy Markdown
Member Author

I prefer placing the docs next to the sources. This worked nicely for JMX GUI and Jakarta. Why do you think we need to create an exception for Flume?

There must be some integration, so that users can find the appender.

Maybe we can move the Flume Appender documentation to its own website and replace the current description in appenders.adoc with a stub. I would prefer to do it, when the /log4j/flume website is ready though. What do you think?

@ppkarwasz ppkarwasz merged commit 39dba0a into 2.x Aug 30, 2024
@ppkarwasz ppkarwasz deleted the feature/2.x/move-flume branch August 30, 2024 09:01
@vy

vy commented Aug 30, 2024

Copy link
Copy Markdown
Member

ppkarwasz added a commit that referenced this pull request Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants