{{ message }}
Repository navigation
Conversation
Contributor
Author
AndrewJSchofield
self-requested a review
October 20, 2026 07:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No test in SimpleAssignorTest covers the case where a member's current
assignment contains a topic that the share group no longer subscribes
to. In that case,
SimpleHomogeneousAssignmentBuilder#revokeUnassignablePartitions removes
the topic from the member's assignment.
This adds a homogeneous test with two members that each hold one
partition of topic 1 and one partition of topic 2, after the group's
subscription changes to topic 1 only. It verifies that topic 2 is
revoked, that each member keeps its partition of topic 1, and that the
remaining partitions of topic 1 are spread so that each member ends up
with two.
Topic 1 has four partitions so that revoking topic 2 leaves each member
below its target, which also checks that the freed capacity is filled
from the unassigned partitions of topic 1.