{{ message }}
Repository navigation
MINOR: Strengthen tests for replaying streams group assignment configs - #23872
Open
gabriellefu wants to merge 3 commits into
Open
gabriellefu wants to merge 3 commits into
gabriellefu wants to merge 3 commits into
Conversation
github-actions
Bot
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #23165. Test-only change.
testStreamsGroupEpochDoesNotIncreaseWhenEveryAssignmentConfigIsAtItsDefaultnow starts the group withnon-default assignment configs, so it fails if replaying a record without configs does not reset them to the
defaults.
testStreamsGroupEpochIncreasesWhenAnAssignmentConfigIsNotAtItsDefault: after the same replay, a group withnum.standby.replicas=2still bumps the group epoch, since the replayed defaults differ from the current configs.AssignmentConfigsImplTestcases forfromRecordwith an empty list and with an unknown key.AssignmentConfigsImpl.DEFAULTinstead ofnew AssignmentConfigsImpl(0, List.of())inGroupMetadataManagerTest.