{{ message }}
mod_proxy_balancer: use apr_isspace when scanning Cookie header#675
Open
arshsmith1 wants to merge 1 commit into
Open
mod_proxy_balancer: use apr_isspace when scanning Cookie header#675arshsmith1 wants to merge 1 commit into
arshsmith1 wants to merge 1 commit into
Conversation
1. get_cookie_param scans the client-supplied Cookie header and hands raw signed char bytes to isspace(). 2. a cookie byte >= 0x80 reaches isspace() as a negative int, outside the unsigned char / EOF domain ctype requires, which is undefined. Switched both calls to apr_isspace, which indexes via unsigned char like the rest of the proxy and http code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
charbytes (start_cookie[-1]and*start_cookie) straight toisspace().charis signed, a cookie byte >= 0x80 reachesisspace()as a negative int, which is outside the unsigned-char / EOF domain the ctype functions are defined for, so the result is undefined.This is reachable on any balancer with a sticky session (
get_cookie_paramis called from find_session_route viabalancer->s->sticky), so the byte is fully attacker-controlled. Switched both calls toapr_isspace, which indexes throughunsigned charand is already what the surrounding proxy/http/server code uses everywhere else.