[improve] keep monitor page selection controls visible in React by butterfly-520-boy · Pull Request #4429 · apache/hertzbeat · GitHub
Skip to content

[improve] keep monitor page selection controls visible in React - #4429

Open
butterfly-520-boy wants to merge 5 commits into
apache:masterfrom
butterfly-520-boy:codex/monitor-select-all-4425
Open

butterfly-520-boy wants to merge 5 commits into
apache:masterfrom
butterfly-520-boy:codex/monitor-select-all-4425

Conversation

@butterfly-520-boy

@butterfly-520-boy butterfly-520-boy commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

What's changed?

Keep current-page selection available above and below Monitor Center's table before any monitor is selected. Both controls use the existing React selection controller, stay synchronized with row selection, and show a mixed state for partial selection. The bottom control shows the selected count and a clear action when applicable.

Selection continues to respect the current authoritative page, permissions, disappeared rows, and loading/error/empty states.

Closes #4425
Closes #4424

Validation

  • Full frontend verification passed: toolchain, architecture, i18n, formatting, lint, type checking, unit tests, production build, bundle budget, dead-code analysis, and diff checks.
  • Unit tests: 1,050 test files and 8,864 tests passed. The first full run exposed four ambiguous selectors in an existing page test after the second count/clear control was added; those assertions were scoped to the bulk action region, and the corrected four-test file passed on the final tree.
  • Focused monitor list view suite: 30 tests passed.
  • Real-backend browser checks: seven current-page monitors, selection in both directions, partial selection, clear, query changes, empty results, and refresh.
  • Contributor confirmed local IDEA validation of the current React version: synchronized top/bottom controls, partial count, and clear selection.

Checklist

  • I have read the contributing guide.
  • Added regression tests for the changed selection controls.
  • Documentation: no new public API or configuration contract.

Add or update API

No backend API or dependency changes.

AI assistance

AI assisted with implementation, tests, migration, and verification.

Human validation

The contributor reviewed and validated this React revision locally through IDEA before authorizing publication.

Risk notes

The real-backend instance contained seven monitors, so cross-page behavior was not exercised manually. The existing current-page selection semantics are preserved. Backend/release end-to-end checks were not run for this frontend-only change.

@github-actions github-actions Bot added the webapp label Oct 6, 2026
@thefullgc

Copy link
Copy Markdown
Member

@butterfly-520-boy butterfly-520-boy changed the title [improve] keep monitor page selection controls visible [improve] keep monitor page selection controls visible in React Oct 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

3 participants