{{ message }}
Repository navigation
Conversation
zqr10159
reviewed
Oct 12, 2026
zqr10159
left a comment
zqr10159
left a comment
Member
There was a problem hiding this comment.
The milliseconds conversion is consistent across initial dispatch, cyclic rescheduling and cron fallback. Please add a scheduling-level regression that verifies the supplied timeUnit is honored and a fractional-second remainder reaches the timer. The new test checks the returned arithmetic, but would not catch scheduling it using the wrong unit. Please run the focused tests against current master before requesting re-review.
…pache#2405) Schedule remaining delays in milliseconds instead of truncating to whole seconds, so short collections no longer drift the interval early. Co-authored-by: Cursor <cursoragent@cursor.com>
…apache#2405) Assert that cyclicJob passes the caller-supplied unit and millisecond remainder into Timer.newTimeout, which arithmetic-only tests would miss. Co-authored-by: Cursor <cursoragent@cursor.com>
xdn-code
force-pushed
the
fix-2405-collection-interval-drift
branch
from
October 12, 2026 14:05
b838f43 to
fd1d181
Compare
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi @MuAnswer and @orangeCatDeveloper, thank you for reporting this and for the clear root-cause analysis.
This change follows the suggested direction of scheduling in milliseconds:
intervalMs / 1000TimeUnit.MILLISECONDStimeUnitargument incyclicJob(...)Test plan
TimerDispatcherTesttestIntervalDispatchPreservesMillisecondRemainderfor the 30s / 300ms casePlease let me know if anything should be adjusted. Thanks again.
Fixes #2405