{{ message }}
Repository navigation
HBASE-30488 BucketCache persistence loses the archived flag of BlockC… - #8799
Open
liuxiaocs7 wants to merge 1 commit into
Open
liuxiaocs7 wants to merge 1 commit into
liuxiaocs7 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
No open issues 🎉
What changed in this PR
Adds coverage and fixes for persisting/restoring the archived flag on BlockCacheKey during BucketCache persistence/recovery (HBASE-30488).
Changes:
- Serialize
BlockCacheKey.isArchived()into the BucketCache persistence protobuf. - Add a parameterized recovery test validating the archived flag survives restart and that region-cached accounting matches expectations.
Review effort: Lite
Copilot stopped reviewing on behalf of
liuxiaocs7 due to an error
October 21, 2026 05:22
wchevreuil
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…acheKey