Use ACSII dash instead of non-ACSII emdash by kgeisz · Pull Request #8795 · apache/hbase · GitHub
Skip to content

Use ACSII dash instead of non-ACSII emdash - #8795

Open
kgeisz wants to merge 1 commit into
apache:HBASE-30087from
kgeisz:HBASE-30087
Open

kgeisz wants to merge 1 commit into
apache:HBASE-30087from
kgeisz:HBASE-30087

Conversation

@kgeisz

@kgeisz kgeisz commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Changes a log message to use ASCII dash to prevent character rendering issues in the log

Change-Id: I90b01f0f073bf7b4b82599a0d58c8e8f0de98ae4
@taklwu
taklwu requested a lite review from Copilot October 21, 2026 05:23

@taklwu taklwu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, running copilot to double check it.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

No open issues 🎉

What changed in this PR

Updates test/log output strings to use ASCII hyphens instead of non-ASCII em dashes to avoid log rendering/encoding issues.

Changes:

  • Replaced an em dash with an ASCII hyphen in a test comment.
  • Replaced an em dash with an ASCII hyphen in a pytest failure log message.
File Description
dev-support/​read-replica/​python/​test/​test_dual_active_cluster_startup.py Uses an ASCII hyphen in a comment describing second-cluster startup behavior.
dev-support/​read-replica/​python/​test/​conftest.py Uses an ASCII hyphen in the “TEST FAILED” log message to avoid non-ASCII characters in logs.

Review effort: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants