HBASE-29270 Isolate replication source test setup and cleanup by Sigma-Ma · Pull Request #8793 · apache/hbase · GitHub
Skip to content

HBASE-29270 Isolate replication source test setup and cleanup - #8793

Open
Sigma-Ma wants to merge 1 commit into
apache:masterfrom
Sigma-Ma:HBASE-29270-isolate-replication-source-test-lifecycle
Open

Sigma-Ma wants to merge 1 commit into
apache:masterfrom
Sigma-Ma:HBASE-29270-isolate-replication-source-test-lifecycle

Conversation

@Sigma-Ma

Copy link
Copy Markdown
Contributor

JIRA: https://issues.apache.org/jira/browse/HBASE-29270.

What changes were proposed in this pull request?

Use a fresh HBase root directory for testServerShutdownRecoveredQueue, restore its temporary configuration in finally, and shut down both mini clusters during class teardown.

Why are the changes needed?

The test reuses the root created by class setup, causing a conflict when writing hbase.version. Temporary settings and incomplete cluster cleanup can also affect other tests.

How was this patch tested?

mvn -pl hbase-server spotless:check

for run in 1 2 3; do
  mvn -B -ntp -pl hbase-server -PrunMediumTests '-Dtest=TestReplicationSource#testServerShutdownRecoveredQueue' -Dsurefire.failIfNoSpecifiedTests=true -Dsurefire.rerunFailingTestsCount=0 "-Dsurefire.reportsDirectory=/tmp/hbase-29270/fixed-${run}-reports" test || exit 1
done

mvn -B -ntp -pl hbase-server -PrunMediumTests -Dtest=TestReplicationSource -Dsurefire.failIfNoSpecifiedTests=true -Dsurefire.rerunFailingTestsCount=0 -Dsurefire.reportsDirectory=/tmp/hbase-29270/full-class-reports test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant