HBASE-30452 Fix shaded testing util JAR test for clean test (addendum) by Sigma-Ma · Pull Request #8789 · apache/hbase · GitHub
Skip to content

HBASE-30452 Fix shaded testing util JAR test for clean test (addendum) - #8789

Merged
PDavid merged 1 commit into
apache:masterfrom
Sigma-Ma:HBASE-30452-addendum
Oct 22, 2026
Merged

HBASE-30452 Fix shaded testing util JAR test for clean test (addendum)#8789
PDavid merged 1 commit into
apache:masterfrom
Sigma-Ma:HBASE-30452-addendum

Conversation

@Sigma-Ma

@Sigma-Ma Sigma-Ma commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Addendum to #8755 under HBASE-30452. Skip the JAR contents check when HBaseTestingUtil is loaded from a class directory. Keep all existing checks when it is loaded from a JAR.

Why are the changes needed?

During clean test, Maven loads HBaseTestingUtil from hbase-server/target/test-classes. Opening this directory with JarFile causes a FileNotFoundException. The previous local validation used package, which did not cover this case.

How was this patch tested?

mvn -s /Users/didi/.m2/settings-public.xml -B -ntp -pl hbase-shaded/hbase-shaded-testing-util-tester -am -Dtest=TestShadedTestingUtilJarContents,TestShadedHBaseTestingUtility -Dsurefire.firstPartGroups=org.apache.hadoop.hbase.testclassification.SmallTests,org.apache.hadoop.hbase.testclassification.MediumTests -Dsurefire.skipSecondPart=true -Dsurefire.rerunFailingTestsCount=0 clean test

mvn -s /Users/didi/.m2/settings-public.xml -B -ntp -pl hbase-shaded/hbase-shaded-testing-util-tester -am -Dtest=TestShadedTestingUtilJarContents,TestShadedHBaseTestingUtility -Dsurefire.firstPartGroups=org.apache.hadoop.hbase.testclassification.SmallTests,org.apache.hadoop.hbase.testclassification.MediumTests -Dsurefire.skipSecondPart=true -Dsurefire.rerunFailingTestsCount=0 package

@Sigma-Ma Sigma-Ma mentioned this pull request Oct 19, 2026
Merged
@Apache9

Apache9 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@Sigma-Ma

Sigma-Ma commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

So this just skip the test in nightly? I think we can merge this first to fix the build problem. But we'd better still find a way to make sure we do not bundle junit libraris in nightly tests.

Yes, the check is skipped in the nightly clean test run. Once this is merged, I'll follow up by running TestShadedTestingUtilJarContents in the nightly shadedjars build, after the shaded JAR has been packaged, so nightly builds still check the actual JAR contents.

PDavid
PDavid approved these changes Oct 20, 2026
View reviewed changes

@PDavid PDavid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks. 👍

@PDavid
PDavid merged commit 2c79c38 into apache:master Oct 22, 2026
8 checks passed
@Sigma-Ma
Sigma-Ma deleted the HBASE-30452-addendum branch October 22, 2026 06:50
PDavid pushed a commit that referenced this pull request Oct 22, 2026
@Sigma-Ma @PDavid
HBASE-30452 Fix shaded testing util JAR test for clean test (addendum) (
046d7d6 
#8789)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Dávid Paksy <paksyd@apache.org>
(cherry picked from commit 2c79c38)
PDavid pushed a commit that referenced this pull request Oct 22, 2026
@Sigma-Ma @PDavid
HBASE-30452 Fix shaded testing util JAR test for clean test (addendum) (
5792754 
#8789)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Dávid Paksy <paksyd@apache.org>
(cherry picked from commit 2c79c38)
@PDavid

PDavid commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Hi @Sigma-Ma,
Thanks for this. The patch does not apply cleanly for branch-2. Can you please a raise a PR for branch-2?

@Sigma-Ma

Sigma-Ma commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Hi @Sigma-Ma, Thanks for this. The patch does not apply cleanly for branch-2. Can you please a raise a PR for branch-2?

Thanks for letting me know. I'll prepare a branch-2 backport, resolve the conflicts, and verify both clean test and package before opening a PR.

This was referenced Oct 22, 2026
Open
Open
@Sigma-Ma

Sigma-Ma commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PDavid PDavid PDavid approved these changes
@Apache9 Apache9 Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sigma-Ma @Apache9 @PDavid