{{ message }}
fix(scale): correct bar height when zoomed with dataZoom filterMode i…#21524
Open
akashsonune wants to merge 2 commits intoapache:masterfrom
Open
fix(scale): correct bar height when zoomed with dataZoom filterMode i…#21524akashsonune wants to merge 2 commits intoapache:masterfrom
akashsonune wants to merge 2 commits intoapache:masterfrom
Conversation
akashsonune
force-pushed
the
fix/issue-19666-bar-datazoom-height
branch
from
eec6f72 to
b7f7313
Compare
Ovilia
reviewed
Mar 3, 2026
Contributor
There was a problem hiding this comment.
I'm not sure val !== extent[0] is expected, please also help test the cases for markPoints to display correctly for single data.
Contributor
Author
There was a problem hiding this comment.
@Ovilia I added tests for markpoint. also I feel the condition val !== extent[0] is needed becuase When the range collapses to a single point, only the value that matches that point should be drawn. Everything else should be ignored (NaN).
Without this check, ALL bars try to draw at the same position, causing the visual bug where zoomed single bar looks like it has value of the highest bar in the series
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s none
Fixes #19666
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed issues
Details
Before: What was the problem?
After: How does it behave after the fixing?
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Merging options
Other information