{{ message }}
Repository navigation
Conversation
After "cd <service>", the QoS telnet command "count <method> <times>" read the times from the third argument, which only exists when the service name is given as well, so "count sayHello 10" printed the statistics once instead of ten times. Read the times from the argument after the method in both forms. After "cd", an invalid times value is now rejected with "Illegal times ...", as it already is without "cd", instead of being ignored. Fixes apache#16530
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16531 +/- ##
============================================
+ Coverage 60.89% 60.92% +0.02%
- Complexity 15 11758 +11743
============================================
Files 1953 1953
Lines 89280 89281 +1
Branches 13477 13477
============================================
+ Hits 54368 54391 +23
+ Misses 29329 29305 -24
- Partials 5583 5585 +2 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What is the purpose of the change?
Fixes #16530.
After
cd <service>, the QoS telnet commandcount <method> <times>read the times fromargs[2], which only exists when the service name is given as well.count sayHello 10aftercdtherefore printed the statistics once instead of ten times.This PR reads the times from the argument after the method in both forms. Without
cdthe parsing is unchanged.Behavior change
cd,count <method> <times>now prints the statistics<times>times instead of once.cd, a non-numeric second argument (for examplecount sayHello x) is now rejected withIllegal times x, must be integer., as it already is withoutcd, instead of being ignored. A third argument aftercdis no longer used as the times.cd, nothing changes.Verification
CountTelnetTest#testCountTimesWithDefaultService(count sayHello 2with a default service) fails before the change (only one result is sent) and passes after it.cdthe result is the same for every input; withcdit differs only when the first argument is not a number and there are at least two arguments.mvn verify -pl dubbo-plugin/dubbo-qos: 108 tests, 0 failures (5 skipped, the@DisabledGenericServiceTest); spotless and checkstyle are clean.cd repro.Echo,count length 3count repro.Echo length 3cd repro.Echo,count 3cd repro.Echo,count length xIllegal times x, must be integer.Checklist